[PGO] Cherry-pick CSPGO LTO linker argument fix#12893
Open
mustartt wants to merge 2 commits intostable/21.xfrom
Open
[PGO] Cherry-pick CSPGO LTO linker argument fix#12893mustartt wants to merge 2 commits intostable/21.xfrom
mustartt wants to merge 2 commits intostable/21.xfrom
Conversation
….dylib (llvm#195020) Context-sensitive PGO is currently broken when using libLTO.dylib with ld on Darwin. 1. `Config.RunCSIRInstr` was not set, and was always false. 2. `ThinLTOCodeGenerator::optimizeModule` always passes an empty PGOOptions. 3. CSPGO flags were only passed for LLD. Now pass to the linker with `-mllvm` prefix. (cherry picked from commit 3a02cca)
) (cherry picked from commit 03d600e)
Author
|
@swift-ci Please test |
Author
|
@swift-ci test |
1 similar comment
Author
|
@swift-ci test |
Author
|
@swift-ci test There are still flaky test |
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Darwin's ld, CSPGO options aren't being passed to libLTO.dylib. This patch follows the precedent to re-parse the flag value after the LTOCodeGenerator creation, since these options are only updated after
lto_codegen_debug_options.rdar://175893503